[xcrysden] [EXTERNAL] Re: Problem with installing xcrysden on Mac OS 10.17.7 (Catalina)

[fink at snaggledworks.com]

On 10/14/21 2:57 PM, Vo, Trinh T (US 398K) wrote:
> Thank you very much.  I am sorry for a long delay in response.  I have been dragged by other projects and do not have time to work on this until now.   I will look at the links you show and work on it to see if it works.
> 
> Trinh
> 
> From: <xcrysden-bounces at democritos.it> on behalf of Gavin Abo <gabo13279 at gmail.com>
> Reply-To: XCrySDen mailing list <xcrysden at democritos.it>
> Date: Monday, August 16, 2021 at 9:19 PM
> To: "xcrysden at democritos.it" <xcrysden at democritos.it>
> Subject: [EXTERNAL] Re: [xcrysden] Problem with installing xcrysden on Mac OS 10.17.7 (Catalina)
> 
> 
> At [1] , I read Xcode 12 has a new "feature":
> 
> Clang now reports an error when you use a function without an explicit declaration when building C or Objective-C code for macOS (-Werror=implicit-function-declaration flag is on). This additional error detection unifies Clang’s behavior for iOS/tvOS and macOS 64-bit targets for this diagnostic. (49917738)
> 
> https://developer.apple.com/documentation/xcode-release-notes/xcode-12-release-notes<https://urldefense.us/v3/__https:/developer.apple.com/documentation/xcode-release-notes/xcode-12-release-notes__;!!PvBDto6Hs4WbVuu7!bF4ebOb40gqymR6j5ATvcPOTdqoNUR2jNOxgGyODnPbY3wofvyrUMLKSGVId8r2D1wK4$>
> 
> At [2], I read that gcc might default to clang with homebrew.  If that is the case, have you tried change it to use gcc [3]?
> 
> If that does not resolve the issue, I'm not a Mac user such that I unfortunately cannot be of much help with that.  Perhaps, there is a Mac user in the list that will respond if they have solution for that error.
> [1] https://github.com/astropy/astropy/issues/10770<https://urldefense.us/v3/__https:/github.com/astropy/astropy/issues/10770__;!!PvBDto6Hs4WbVuu7!bF4ebOb40gqymR6j5ATvcPOTdqoNUR2jNOxgGyODnPbY3wofvyrUMLKSGVId8ou0i-ZE$>
> [2] https://github.com/openvenues/libpostal/issues/511<https://urldefense.us/v3/__https:/github.com/openvenues/libpostal/issues/511__;!!PvBDto6Hs4WbVuu7!bF4ebOb40gqymR6j5ATvcPOTdqoNUR2jNOxgGyODnPbY3wofvyrUMLKSGVId8uRXlS2t$>
> [3] https://apple.stackexchange.com/questions/245891/installed-gcc-with-homebrew-now-how-to-use-that-gcc-instead-of-clang<https://urldefense.us/v3/__https:/apple.stackexchange.com/questions/245891/installed-gcc-with-homebrew-now-how-to-use-that-gcc-instead-of-clang__;!!PvBDto6Hs4WbVuu7!bF4ebOb40gqymR6j5ATvcPOTdqoNUR2jNOxgGyODnPbY3wofvyrUMLKSGVId8ixlA3xZ$>
> On 8/16/2021 11:02 AM, Vo, Trinh T (US 398K) wrote:
> Dear Developer,
> 
> I compiled from source code of xcrysden on my new laptop, and I encountered the following errors:
> 
> #   Compiling XCRYSDEN C-code  #
> #                              #
> #------------------------------#
> 
> cd C; /Applications/Xcode.app/Contents/Developer/usr/bin/make "TOPDIR=/Users/trinhvo/xcrysden-1.6.2" compile
> make  TOPDIR=/Users/trinhvo/xcrysden-1.6.2
> gcc  -ffast-math -funroll-loops -fPIC -pedantic -Wall    -I/usr/include/tcl8.6 -I/usr/local/Cellar/tcl-tk/8.6.11_1/include -I/usr/local/Cellar/tcl-tk/8.6.11_1/include    -c xcAppInit.c
> xcAppInit.c:407:3: error: implicit declaration of function 'XGetErrorText' is
>        invalid in C99 [-Werror,-Wimplicit-function-declaration]
>    XGetErrorText(display,event->error_code,buffer,sizeof(buffer)-1);
>    ^
> xcAppInit.c:1834:7: warning: 'glDrawBuffer' is deprecated: first deprecated in
>        macOS 10.14 - OpenGL API deprecated. (Define GL_SILENCE_DEPRECATION to
>        silence these warnings) [-Wdeprecated-declarations]
>        glDrawBuffer(GL_BACK);

Implicit declaration errors are due to not including a header declaring 
that function (this is critical with ARM chips). Homebrew's formula 
apparently doesn't pull in X11 -I calls, so it's naturally not finding 
X11/Xlib.h that declares XGetErrorText. A quick glance suggests that 
their Tcl/TK is Aqua and not X11 based. I've no idea what will happen 
when X11 based xcrysden interacts with Aqua Tcl/TK.

FWIW, Fink's xcrysden builds and works on Catalina and Big Sur.

Hanspeter
(Fink's xcrysden maintainer)